linux-kernel - Re: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550F6799.1000301@huawei.com>
Date:	Mon, 23 Mar 2015 09:08:41 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	Jiang Liu <jiang.liu@...ux.intel.com>, <linux-pci@...r.kernel.org>,
	Yinghai Lu <yinghai@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	Marc Zyngier <marc.zyngier@....com>,
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>, <x86@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Tony Luck <tony.luck@...el.com>, <linux-ia64@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"Guan Xuetao" <gxt@...c.pku.edu.cn>, <linux-alpha@...r.kernel.org>,
	<linux-m68k@...ts.linux-m68k.org>, Liviu Dudau <liviu@...au.co.uk>,
	"Arnd Bergmann" <arnd@...db.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v6 09/30] PCI: Separate pci_host_bridge creation out of
 pci_create_root_bus()

>> +struct pci_host_bridge *pci_create_host_bridge(
>> +        struct device *parent, u32 db, struct list_head *resources)
>> +{
>> +    int error;
>> +    int bus = PCI_BUSNUM(db);
>> +    int domain = PCI_DOMAIN(db);
>> +    struct pci_host_bridge *host;
>> +    struct resource_entry *window, *n;
>> +
>> +    host = kzalloc(sizeof(*host), GFP_KERNEL);
>> +    if (!host)
>> +        return NULL;
>> +
>> +    host->busnum = bus;
>> +    host->domain = domain;
>> +    /* If support CONFIG_PCI_DOMAINS_GENERIC, use
>> +     * pci_host_assign_domain_nr() to assign domain
>> +     * number instead PCI_DOMAIN(db).
>> +     */
>> +    pci_host_assign_domain_nr(host);
> 
> At this point, host->dev.parent has not been assigned. However, when calling pci_host_assign_domain_nr(host), it calls pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly w/o checking if parent is NULL. This ended up causing NULL pointer exception when I do the test.
> 
> I think we need to moveo host->dev.parent = parent before calling pci_host_assign_domain_nr(host).

Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent before pci_host_assign_domain_nr().

Thanks!
Yijing.

> 
> .
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/