linux-kernel - [PATCH] udf: NULL dereference at udf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1427091109-1642-1-git-send-email-changwoo.m@gmail.com>
Date:	Mon, 23 Mar 2015 02:11:49 -0400
From:	Changwoo Min <changwoo.m@...il.com>
To:	jack@...e.cz, linux-kernel@...r.kernel.org
Cc:	taesoo@...ech.edu, changwoo@...ech.edu, sanidhya@...ech.edu,
	blee@...ech.edu, csong84@...ech.edu,
	Changwoo Min <changwoo.m@...il.com>
Subject: [PATCH] udf: NULL dereference at udf_symlink() on error

There is no check for udf_tgetblk(), which could return NULL, in udf_symlink(). 
So there is a possibility of returning NULL under heavy memory pressure and 
possibility of NULL dereference. 

Signed-off-by: Changwoo Min <changwoo.m@...il.com>
---
 fs/udf/namei.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index 33b246b..ed2f221 100644
--- a/fs/udf/namei.c
+++ b/fs/udf/namei.c
@@ -902,6 +902,10 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry,
 				iinfo->i_location.partitionReferenceNum,
 				0);
 		epos.bh = udf_tgetblk(sb, block);
+		if (!epos.bh) {
+			err = -ENOMEM;
+			goto out_no_entry;
+		}
 		lock_buffer(epos.bh);
 		memset(epos.bh->b_data, 0x00, bsize);
 		set_buffer_uptodate(epos.bh);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/