linux-kernel - Re: [PATCH] ext3: Remove useless condition in if statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1503231130060.1578@localhost.localdomain>
Date:	Mon, 23 Mar 2015 11:30:44 +0100 (CET)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Wei Yuan <weiyuan.wei@...wei.com>
cc:	jack@...e.cz, akpm@...ux-foundation.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	lizefan@...wei.com
Subject: Re: [PATCH] ext3: Remove useless condition in if statement.

On Fri, 20 Mar 2015, Wei Yuan wrote:

> Date: Fri, 20 Mar 2015 11:09:10 +0800
> From: Wei Yuan <weiyuan.wei@...wei.com>
> To: jack@...e.cz, akpm@...ux-foundation.org, adilger.kernel@...ger.ca
> Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
>     lczerner@...hat.com, lizefan@...wei.com
> Subject: [PATCH] ext3: Remove useless condition in if statement.
> 
> In this if statement, the previous condition is useless, the later one has covered it.

Nice that you've send this ext3 counterpart for ext4 patch. Thanks!

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> 
> Signed-off-by: Weiyuan <weiyuan.wei@...wei.com>
> ---
>  fs/ext3/xattr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c
> index c6874be..24215dc 100644
> --- a/fs/ext3/xattr.c
> +++ b/fs/ext3/xattr.c
> @@ -546,8 +546,7 @@ ext3_xattr_set_entry(struct ext3_xattr_info *i, struct ext3_xattr_search *s)
>  		free += EXT3_XATTR_LEN(name_len);
>  	}
>  	if (i->value) {
> -		if (free < EXT3_XATTR_SIZE(i->value_len) ||
> -		    free < EXT3_XATTR_LEN(name_len) +
> +		if (free < EXT3_XATTR_LEN(name_len) +
>  			   EXT3_XATTR_SIZE(i->value_len))
>  			return -ENOSPC;
>  	}
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/