linux-kernel - Re: [PATCH] mfd: dln2: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 12:28:44 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: dln2: use msecs_to_jiffies for time conversion

On Mon, 16 Mar 2015, Nicholas Mc Guire wrote:

> Converting milliseconds to jiffies by "val * HZ / 1000" is technically
> OK but msecs_to_jiffies(val) is the cleaner solution and handles all
> corner cases correctly. This is a minor API consolidation only and
> should make things more readable.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> Patch was compile tested with x86_64_defconfig + CONFIG_MFD_DLN2=m
> 
> Patch is agianst 4.0-rc3 (localversion-next is -next-20150316)
> 
>  drivers/mfd/dln2.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
> index 1be9bd1..704e189 100644
> --- a/drivers/mfd/dln2.c
> +++ b/drivers/mfd/dln2.c
> @@ -435,7 +435,7 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
>  	struct dln2_response *rsp;
>  	struct dln2_rx_context *rxc;
>  	struct device *dev = &dln2->interface->dev;
> -	const unsigned long timeout = DLN2_USB_TIMEOUT * HZ / 1000;
> +	const unsigned long timeout = msecs_to_jiffies(DLN2_USB_TIMEOUT);
>  	struct dln2_mod_rx_slots *rxs = &dln2->mod_rx_slots[handle];
>  	int size;
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/