linux-kernel - Re: [PATCH] sm750fb: Fix C99 comment and if-else braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 18:18:00 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:	teddy.wang@...iconmotion.com, gregkh@...uxfoundation.org,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sm750fb: Fix C99 comment and if-else braces

On Fri, Mar 20, 2015 at 07:54:56PM +0530, Amitoj Kaur Chawla wrote:
> The edits have been made to fix C99 Comment and properly indent
> the if-else statements with the braces.
i think you are doing multiple types of changes in one patch.
better to send it in a series of two, one for the C99 and the other
for the if-else. and there are few more places in that file where C99
is used, any reason why you have chosen only one?

scripts/checkpatch.pl --strict -f drivers/staging/sm750fb/ddk750_chip.c | grep C99 | wc -l
6

and, your patch is not applying, please refresh your patch
against staging-testing.

regards
sudip
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/