linux-kernel - Re: [Gta04-owner] [PATCH 08/14] twl4030_charger: allow max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a05a88a7a3ea4519ada7216ab5bfe097@rommel.stw.uni-erlangen.de>
Date:	Mon, 23 Mar 2015 13:14:50 +0100
From:	jake42 <jake42@...mel.stw.uni-erlangen.de>
To:	NeilBrown <neil@...wn.name>
Cc:	Sebastian Reichel <sre@...nel.org>, <linux-api@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <inux-pm@...r.kernel.org>,
	Pavel Machek <pavel@....cz>, <linux-omap@...r.kernel.org>,
	Lee Jones <lee.jones@...aro.org>,
	List for communicating with real GTA04 owners 
	<gta04-owner@...delico.com>
Subject: Re: [Gta04-owner] [PATCH 08/14] twl4030_charger: allow max_current to be managed via sysfs.

Hello Neil,

some suggestions:

On 23.03.2015 00:20, NeilBrown wrote:
> From: NeilBrown <neilb@...e.de>
> diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030
> b/Documentation/ABI/testing/sysfs-class-power-twl4030
> new file mode 100644
> index 000000000000..06092209d851
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-power-twl4030
> @@ -0,0 +1,15 @@
> +What: /sys/class/power_supply/twl4030_ac/max_current
> +      /sys/class/power_supply/twl4030_usb/max_current
> +Description:
> +	Read/Write limit on current which which may
one less which                        ^^
> +	be drawn from the ac (Accessory Charger) or
> +	USB port.
> +
> +	Value is in micro-Amps.
> +
> +	Value is set automatically to an appropriate
> +	value when a cable is plugged on unplugged.
s/on/or                               ^^
> +
> +	Value can the set by writing to the attribute.
                   ^^ be set?
> +	The change will only persist until the next
> +	plug event.  These event are reported via udev.

Regards
Jake

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/