linux-kernel - Re: [PATCH v2] dts: cubox: Map gpio-keys to gpio3 8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150323133252.GE28410@dragon>
Date:	Mon, 23 Mar 2015 21:32:54 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	George Joseph <george.joseph@...rview5.com>,
	Russell King <linux@....linux.org.uk>
Cc:	Sascha Hauer <kernel@...gutronix.de>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dts: cubox: Map gpio-keys to gpio3 8

On Mon, Mar 16, 2015 at 03:53:49PM -0600, George Joseph wrote:
> The Cubox has a recessed button between the HDMI and RJ-45 connectors
> that wasn't mapped in the device tree, so I've mapped it to gpio-keys
> BTN_0.
> 
> Signed-off-by: George Joseph <george.joseph@...rview5.com>
> Tested-by: George Joseph <george.joseph@...rview5.com>

Russell,

Are you fine with this patch?

Shawn

> ---
>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index 6a524ca..de6e3a8 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -3,6 +3,8 @@
>   */
>  #include "imx6qdl-microsom.dtsi"
>  #include "imx6qdl-microsom-ar8035.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	ir_recv: ir-receiver {
> @@ -66,6 +68,18 @@
>  		spdif-controller = <&spdif>;
>  		spdif-out;
>  	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pinctrl_gpio_key>;
> +		pinctrl-names = "default";
> +
> +		button_0 {
> +			label = "Button 0";
> +			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;
> +			linux,code = <BTN_0>;
> +		};
> +	};
>  };
>  
>  &hdmi {
> @@ -170,6 +184,12 @@
>  				MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x13059
>  			>;
>  		};
> +
> +		pinctrl_gpio_key: gpio-key {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_DA8__GPIO3_IO08	0x17059
> +			>;
> +		};
>  	};
>  };
>  
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/