linux-kernel - Re: [PATCH 1/5] perf kmem: Print big numbers using thousands' group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150323140838.GU16485@kernel.org>
Date:	Mon, 23 Mar 2015 11:08:38 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Minchan Kim <minchan@...nel.org>,
	Joonsoo Kim <js1304@...il.com>
Subject: Re: [PATCH 1/5] perf kmem: Print big numbers using thousands' group

Em Mon, Mar 23, 2015 at 03:30:40PM +0900, Namhyung Kim escreveu:
> Like perf stat, this makes easy to read the numbers on stat like below:
> 
>   # perf kmem stat
> 
>   SUMMARY
>   =======
>   Total bytes requested: 9,770,900
>   Total bytes allocated: 9,782,712
>   Total bytes wasted on internal fragmentation: 11,812
>   Internal fragmentation: 0.120744%
>   Cross CPU allocations: 74/152,819
> 
> Suggested-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>  static void print_result(struct perf_session *session)
> @@ -706,6 +707,8 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
>  	symbol__init(&session->header.env);
>  
>  	if (!strcmp(argv[0], "stat")) {
> +		setlocale(LC_ALL, "");
> +

Applying, but I think it is better to have this call in perf's main()
routine, to avoid repeating it in each tool, as 'builtin-stat' already
does this, but as this affects all tools, some further testing is
needed, I think, or does anyone see any problem with that?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/