linux-kernel - Re: [PATCH 19/35 linux-next] virtio_mmio: constify of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427120430.3726.28.camel@arm.com>
Date:	Mon, 23 Mar 2015 14:20:30 +0000
From:	Pawel Moll <pawel.moll@....com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"virtualization@...ts.linux-foundation.org" 
	<virtualization@...ts.linux-foundation.org>,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 19/35 linux-next] virtio_mmio: constify of_device_id
 array

On Mon, 2015-03-16 at 19:20 +0000, Fabian Frederick wrote:
> of_device_id is always used as const.
> (See driver.of_match_table and open firmware functions)
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/virtio/virtio_mmio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 9c877d2..0ce8cda 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -671,7 +671,7 @@ static void vm_unregister_cmdline_devices(void)
>  
>  /* Platform driver */
>  
> -static struct of_device_id virtio_mmio_match[] = {
> +static const struct of_device_id virtio_mmio_match[] = {
>  	{ .compatible = "virtio,mmio", },
>  	{},
>  };

Acked-by: Pawel Moll <pawel.moll@....com>

Thanks!

Pawel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/