linux-kernel - Re: [PATCH 1/1] 9p: correctly check empty xattr key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y4mnn4s0.fsf@linux.vnet.ibm.com>
Date:	Mon, 23 Mar 2015 20:24:07 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Taesoo Kim <tsgatesv@...il.com>, ericvh@...il.com,
	rminnich@...dia.gov, lucho@...kov.net,
	v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Cc:	taesoo@...ech.edu, changwoo@...ech.edu, sanidhya@...ech.edu,
	blee@...ech.edu, csong84@...ech.edu,
	Taesoo Kim <tsgatesv@...il.com>
Subject: Re: [PATCH 1/1] 9p: correctly check empty xattr key

Taesoo Kim <tsgatesv@...il.com> writes:

> When xattr name (key) is empty (""), correctly return -EINVAL
> error. Not sure how previous xattr_set_acl() performs with
> any xattr key for get/set().

Did you test this ?

>
> Signed-off-by: Taesoo Kim <tsgatesv@...il.com>
> ---
>  fs/9p/acl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/acl.c b/fs/9p/acl.c
> index 8482f2d..295bf25 100644
> --- a/fs/9p/acl.c
> +++ b/fs/9p/acl.c
> @@ -237,7 +237,7 @@ static int v9fs_xattr_get_acl(struct dentry *dentry, const char *name,
>  	struct posix_acl *acl;
>  	int error;
>  
> -	if (strcmp(name, "") != 0)
> +	if (strcmp(name, "") == 0)
>  		return -EINVAL;

We get the name in get_acl callback after xattr_resolve_name. ie, the
value of name is

name = strcmp_prefix(passed_name, "system.posix_acl_access");
We should find that name "" isn't it ?

>  
>  	v9ses = v9fs_dentry2v9ses(dentry);
> @@ -287,7 +287,7 @@ static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name,
>  	struct v9fs_session_info *v9ses;
>  	struct inode *inode = dentry->d_inode;
>  
> -	if (strcmp(name, "") != 0)
> +	if (strcmp(name, "") == 0)
>  		return -EINVAL;
>  
>  	v9ses = v9fs_dentry2v9ses(dentry);
> -- 
> 2.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/