[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <551032AA.3060906@st.com>
Date: Mon, 23 Mar 2015 16:35:06 +0100
From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
To: Richard Cochran <richardcochran@...il.com>,
<netdev@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>,
Ariel Elior <ariel.elior@...gic.com>,
Arnd Bergmann <arnd@...aro.org>,
Baolin Wang <baolin.wang@...aro.org>,
Ben Hutchings <ben@...adent.org.uk>,
Bruce Allan <bruce.w.allan@...el.com>,
Carolyn Wyborny <carolyn.wyborny@...el.com>,
Chris Metcalf <cmetcalf@...hip.com>,
David Miller <davem@...emloft.net>,
Frank Li <Frank.Li@...escale.com>,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
John Stultz <john.stultz@...aro.org>,
Luwei Zhou <b45643@...escale.com>,
Matthew Vick <matthew.vick@...el.com>,
Michael Chan <mchan@...adcom.com>,
Prashant Sreedharan <prashant@...adcom.com>,
Shradha Shah <sshah@...arflare.com>,
Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
Sonic Zhang <sonic.zhang@...log.com>,
Stefan Sørensen
<stefan.sorensen@...ctralink.com>,
Thomas Gleixner <tglx@...utronix.de>,
Tom Lendacky <thomas.lendacky@....com>,
Rayagond K <rayagond@...avyalabs.com>
Subject: Re: [PATCH net-next V2 17/23] ptp: stmmac: convert to the 64 bit
get/set time methods.
On 3/21/2015 10:39 PM, Richard Cochran wrote:
> This device stores the number of seconds in a 32 bit register. So
> more work is needed on this driver before the year 2038 comes around.
>
> Compile tested only.
I cannot perform tests on my side, unfortunately. I have no setup at
this moment. Added Rayagond on copy too
Peppe
>
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> index c5ee79d8..172f318 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> @@ -105,7 +105,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta)
> * Description: this function will read the current time from the
> * hardware clock and store it in @ts.
> */
> -static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts)
> +static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec64 *ts)
> {
> struct stmmac_priv *priv =
> container_of(ptp, struct stmmac_priv, ptp_clock_ops);
> @@ -135,7 +135,7 @@ static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts)
> * hardware clock.
> */
> static int stmmac_set_time(struct ptp_clock_info *ptp,
> - const struct timespec *ts)
> + const struct timespec64 *ts)
> {
> struct stmmac_priv *priv =
> container_of(ptp, struct stmmac_priv, ptp_clock_ops);
> @@ -168,8 +168,8 @@ static struct ptp_clock_info stmmac_ptp_clock_ops = {
> .pps = 0,
> .adjfreq = stmmac_adjust_freq,
> .adjtime = stmmac_adjust_time,
> - .gettime = stmmac_get_time,
> - .settime = stmmac_set_time,
> + .gettime64 = stmmac_get_time,
> + .settime64 = stmmac_set_time,
> .enable = stmmac_enable,
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists