linux-kernel - Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 18:50:53 +0300
From:	Alexey Kodanev <alexey.kodanev@...cle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

Hi Eric,
On 03/23/2015 05:38 PM, Eric Dumazet wrote:
> On Mon, 2015-03-23 at 13:38 +0300, Alexey Kodanev wrote:
> \
>> @@ -1538,7 +1525,7 @@ do_time_wait:
>>   					    &ipv6_hdr(skb)->saddr, th->source,
>>   					    &ipv6_hdr(skb)->daddr,
>>   					    ntohs(th->dest), tcp_v6_iif(skb));
>> -		if (sk2 != NULL) {
>> +		if (sk2) {
>>   			struct inet_timewait_sock *tw = inet_twsk(sk);
>>   			inet_twsk_deschedule(tw, &tcp_death_row);
>>   			inet_twsk_put(tw);
> And please refrain adding such cleanup changes in a bug fix.

Sure, I will. Thank you for review!

Best regards,
Alexey

> Thanks !
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/