linux-kernel - Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201503231802.28977@pali>
Date:	Mon, 23 Mar 2015 18:02:28 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Santiago Gala <sgala@...che.org>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

On Monday 23 March 2015 12:39:48 Hans de Goede wrote:
> Hi,
> 
> On 22-03-15 14:46, Pali Rohár wrote:
> > This patch adds detection of trackstick for v7 protocol
> > devices. Code in this patch is used in official Dell
> > touchpad linux drivers for Dell models: Dell Latitude
> > E5250/5250, E5450/5450, E5550/5550
> > 
> > Detection code and base reg for alps v3 rushmore and v7
> > devices is exacly same.
> > 
> > Also user in bug
> > https://bugzilla.kernel.org/show_bug.cgi?id=94801 reported
> > that Toshiba Sattellite Z30-A-1DG has only alps v7 touchpad
> > device without trackstick and kernel reports to userspace
> > also redundant trackstick device.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> 
> Looks good, but has this been tested on a laptop which
> actually has a v7 pad + trackstick? I would like to see this
> actually tested on at least one such laptop before it gets
> merged.
> 
> Regards,
> 
> Hans
> 

I did not tested my patch on any v7 touchpad-only laptop.

But I guess Dell should have tested it... Of course we can wait 
until somebody test this patch and after that we will merge it.

@Santiago: Can you test this patch? You also have v7 touchpad 
only laptop (without trackstick).

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)