linux-kernel - [PATCH] checkkconfigsymbols.py: fix sorted output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1427132449-24941-1-git-send-email-valentinrothberg@gmail.com>
Date:	Mon, 23 Mar 2015 18:40:49 +0100
From:	Valentin Rothberg <valentinrothberg@...il.com>
To:	gregkh@...uxfoundation.org
Cc:	stefan.hengelein@....de, linux-kernel@...r.kernel.org,
	pebolle@...cali.nl, Valentin Rothberg <valentinrothberg@...il.com>
Subject: [PATCH] checkkconfigsymbols.py: fix sorted output

Commit b1a3f243485f ("checkkconfigsymbols.py: make it Git aware")
mistakenly removed to print undefined Kconfig symbols in alphabetical
order.  Furthermore, the script does not print anything anymore when the
entire tree is checked (i.e., when no commit is specified).

This patch restores the sorted output and adds the missing print for the
default case.  Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.

Signed-off-by: Valentin Rothberg <valentinrothberg@...il.com>
---
This patch is written against the char-misc-next branch in Greg's
char-misc git tree; the mentioned commit is not yet in linux-next.

The char-misc tree can be found at
  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
---
 scripts/checkkconfigsymbols.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index ce9ca60808b8..74086a583d8d 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py
@@ -112,14 +112,15 @@ def main():
         undefined_b = check_symbols()
 
         # report cases that are present for the commit but not before
-        for feature in undefined_b:
+        for feature in sorted(undefined_b):
             # feature has not been undefined before
             if not feature in undefined_a:
-                files = undefined_b.get(feature)
+                files = sorted(undefined_b.get(feature))
                 print "%s\t%s" % (feature, ", ".join(files))
             # check if there are new files that reference the undefined feature
             else:
-                files = undefined_b.get(feature) - undefined_a.get(feature)
+                files = sorted(undefined_b.get(feature) -
+                               undefined_a.get(feature))
                 if files:
                     print "%s\t%s" % (feature, ", ".join(files))
 
@@ -129,8 +130,9 @@ def main():
     # default to check the entire tree
     else:
         undefined = check_symbols()
-        for feature in undefined:
-            files = undefined.get(feature)
+        for feature in sorted(undefined):
+            files = sorted(undefined.get(feature))
+            print "%s\t%s" % (feature, ", ".join(files))
 
 
 def execute(cmd):
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/