linux-kernel - Re: [PATCH v5 08/12] mfd: axp20x: Add AXP22x regulator information to DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v673WWV4q5eEGQF-nhX=Zq=ciD=yXgei-eZjKMWPDxKv4A@mail.gmail.com>
Date:	Mon, 23 Mar 2015 10:43:04 -0700
From:	Chen-Yu Tsai <wens@...e.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Chen-Yu Tsai <wens@...e.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Kumar Gala <galak@...eaurora.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	devicetree <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH v5 08/12] mfd: axp20x: Add AXP22x regulator information to
 DT bindings

On Mon, Mar 23, 2015 at 4:54 AM, Lee Jones <lee.jones@...aro.org> wrote:
> On Tue, 10 Mar 2015, Chen-Yu Tsai wrote:
>
>> Add the list of regulators for AXP22x to the DT bindings.
>> This includes the names and supply names.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/axp20x.txt | 27 ++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
>> index 3914a3f91ff6..0fc2f1f35cef 100644
>> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
>> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
>> @@ -49,6 +49,33 @@ LDO3               : LDO           : ldo3in-supply
>>  LDO4         : LDO           : ldo24in-supply        : shared supply
>>  LDO5         : LDO           : ldo5in-supply
>>
>> +
>
> Nit: I'm not keen on double line spacing.
>
>> +AXP221 regulators, type, and corresponding input supply names:
>> +
>> +Regulator      Type            Supply Name             Notes
>> +---------      ----            -----------             -----
>> +DCDC1                : DC-DC buck    : vin1-supply
>> +DCDC2                : DC-DC buck    : vin2-supply
>> +DCDC3                : DC-DC buck    : vin3-supply
>> +DCDC4                : DC-DC buck    : vin4-supply
>> +DCDC5                : DC-DC buck    : vin5-supply
>> +DC1SW                : On/Off Switch : dcdc1-supply          : DCDC1 secondary output
>> +DC5LDO               : LDO           : dcdc5-supply          : input from DCDC5
>> +ALDO1                : LDO           : aldoin-supply         : shared supply
>> +ALDO2                : LDO           : aldoin-supply         : shared supply
>> +ALDO3                : LDO           : aldoin-supply         : shared supply
>> +DLDO1                : LDO           : dldoin-supply         : shared supply
>> +DLDO2                : LDO           : dldoin-supply         : shared supply
>> +DLDO3                : LDO           : dldoin-supply         : shared supply
>> +DLDO4                : LDO           : dldoin-supply         : shared supply
>> +ELDO1                : LDO           : eldoin-supply         : shared supply
>> +ELDO2                : LDO           : eldoin-supply         : shared supply
>> +ELDO3                : LDO           : eldoin-supply         : shared supply
>> +LDO_IO0              : LDO           : ips-supply            : GPIO 0
>> +LDO_IO1              : LDO           : ips-supply            : GPIO 1
>> +RTC_LDO              : LDO           : ips-supply            : always on
>> +
>> +
>
> Nit: I'm not keen on double line spacing.

Ok. I can get rid of them. IMHO it makes different sections clearer though.
I assume you don't want them in the original axp20x patches either?

ChenYu

>>  Example:
>>
>>  axp209: pmic@34 {
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/