linux-kernel - Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo6zfA7t-CeYx1_aBYEcV=LFueWYE_bndH-s-ktjL_goPg@mail.gmail.com>
Date:	Mon, 23 Mar 2015 13:18:03 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	Yijing Wang <wangyijing@...wei.com>,
	"kbuild-all@...org" <kbuild-all@...org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24:
 sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?

Hi Yijing,

On Mon, Mar 23, 2015 at 1:08 PM, kbuild test robot
<fengguang.wu@...el.com> wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/enumeration-yw7
> head:   2681a1f3d2011d4cbb888d3e974a13bda85d225c
> commit: 2577ed41b6a6db3117713069e49b72091b60c867 [32/35] PCI: rename to pci_find_host_bridge()
> reproduce:
>   # apt-get install sparse
>   git checkout 2577ed41b6a6db3117713069e49b72091b60c867
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.

It does look like pci_find_host_bridge() is only used inside
drivers/pci/host-bridge.c and could be static.  Given that it's only
used there, it doesn't even need to be renamed, so maybe you could
even just drop the rename patch, too.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/