lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <550F8F69.2090005@huawei.com>
Date:	Mon, 23 Mar 2015 11:58:33 +0800
From:	Yunlong Song <yunlong.song@...wei.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	<a.p.zijlstra@...llo.nl>, <paulus@...ba.org>, <mingo@...hat.com>,
	<acme@...nel.org>, <linux-kernel@...r.kernel.org>,
	<wangnan0@...wei.com>
Subject: Re: [PATCH] perf tools: Remove (null) value of "Sort order" for perf
 mem report

On 2015/3/23 8:44, Namhyung Kim wrote:
> Hi Yunlong,
> 
> On Thu, Mar 19, 2015 at 09:58:32PM +0800, Yunlong Song wrote:
>> When '--sort' is not set, 'perf mem report" will print a null pointer as
>> the output value of sort order, so fix it.
>>
>> Example:
>>
>> Before this patch:
>>
>>  $ perf mem report
>>  # To display the perf.data header info, please use --header/--header-only options.
>>  #
>>  # Samples: 18  of event 'cpu/mem-loads/pp'
>>  # Total weight : 188
>>  # Sort order   : (null)
>>  #
>>  ...
>>
>> After this patch:
>>
>>  $ perf mem report
>>  # To display the perf.data header info, please use --header/--header-only options.
>>  #
>>  # Samples: 18  of event 'cpu/mem-loads/pp'
>>  # Total weight : 188
>>  #
>>  ...
> 
> I think it'd be better to show default sort order in this case.
> 
> 

Agree, I have changed that into a default sort order in PATCH v2, thanks.

-- 
Thanks,
Yunlong Song

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ