linux-kernel - Re: [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427143934.16851.46.camel@perches.com>
Date:	Mon, 23 Mar 2015 13:52:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrei Maresu <andreimaresu@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Dma: at_hdmac_regs fixed a space coding style issue

On Mon, 2015-03-23 at 22:37 +0200, Andrei Maresu wrote:
> The following chaeckpatch error was fixed:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h
[]
> @@ -53,7 +53,7 @@
> 
>  #define	AT_DMA_CHER	0x28	/* Channel Handler Enable Register */
>  #define		AT_DMA_ENA(x)	(0x1 << (x))
> -#define		AT_DMA_SUSP(x)	(0x1 << ( 8 + (x)))
> +#define		AT_DMA_SUSP(x)	(0x1 << (8 + (x)))
>  #define		AT_DMA_KEEP(x)	(0x1 << (24 + (x)))

Meh.

I think this isn't much of an improvement.
This was likely done to align these AT_ defines.

Another option might be to use the BIT macro.

#define		AT_DMA_SUSP(x)	BIT((x) + 8)
#define		AT_DMA_KEEP(x)	BIT((x) + 24)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/