linux-kernel - Re: [PATCH] C6x: time: Ensure consistency in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 19:27:23 -0500
From:	Nishanth Menon <nm@...com>
To:	Mark Salter <msalter@...hat.com>,
	Aurelien Jacquiot <a-jacquiot@...com>
CC:	linux-c6x-dev@...ux-c6x.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] C6x: time: Ensure consistency in __init

Hi,

On 03/07/2015 03:39 AM, Nishanth Menon wrote:
> time_init invokes timer64_init (which is __init annotation)
> since all of these are invoked at init time, lets maintain
> consistency by ensuring time_init is marked appropriately
> as well.
> 
> This fixes the following warning with CONFIG_DEBUG_SECTION_MISMATCH=y
> 
> WARNING: vmlinux.o(.text+0x3bfc): Section mismatch in reference from the function time_init() to the function .init.text:timer64_init()
> The function time_init() references
> the function __init timer64_init().
> This is often because time_init lacks a __init
> annotation or the annotation of timer64_init is wrong.
> 
> Fixes: 546a39546c64 ("C6X: time management")
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> 
> Newbie warning: this is my first foray at c6x, So, appreciate a little
> gentleness while killing me ;)
> 
> Applies on latest master:
> af13e867133a Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
> 

Gentle ping.

> 
>  arch/c6x/kernel/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/c6x/kernel/time.c b/arch/c6x/kernel/time.c
> index 356ee84cad95..04845aaf5985 100644
> --- a/arch/c6x/kernel/time.c
> +++ b/arch/c6x/kernel/time.c
> @@ -49,7 +49,7 @@ u64 sched_clock(void)
>  	return (tsc * sched_clock_multiplier) >> SCHED_CLOCK_SHIFT;
>  }
>  
> -void time_init(void)
> +void __init time_init(void)
>  {
>  	u64 tmp = (u64)NSEC_PER_SEC << SCHED_CLOCK_SHIFT;
>  
> 
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/