linux-kernel - Re: [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5511B1EC.7080406@ti.com>
Date:	Tue, 24 Mar 2015 20:50:20 +0200
From:	Tero Kristo <t-kristo@...com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>, <mturquette@...aro.org>,
	<sboyd@...eaurora.org>
CC:	<tony@...mide.com>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes

On 03/16/2015 12:40 PM, Peter Ujfalusi wrote:
> Hi,
>
> This series will fix the following error during boot (both DT and legacy boot):
> [    0.307739] omap_hwmod: mcbsp2: _wait_target_ready failed: -16
> [    0.307769] omap_hwmod: mcbsp2: cannot be enabled for reset (3)
>
> The clock definitions/aliases for McBSP ports were not correct.
>
> In case of DT boot we still have the following warning printed from hwmod:
> [    0.222900] omap_hwmod: mcbsp2_sidetone using broken dt data from mcbsp
> [    0.225311] omap_hwmod: mcbsp3_sidetone using broken dt data from mcbsp
>
> These are there because mcbsp is using two hwmods in the DT and hwmod prints
> out a warning for these. In legacy mode we also have 2 hwmods for McBSP2/3.
> One for the McBSP itself and the other for the sidetone block attached to them.
> I'll try to look into this one next.
>
> Since this series fixes the _wait_target_ready issue, can this be sent for 4.0?

I don't think this is a critical fix, the wait_target_ready issue has 
been around for ages. Queued for 4.1 though, thanks.

-Tero

>
> Regards,
> Peter
> ---
> Peter Ujfalusi (2):
>    clk: ti: clk-3xxx: Correct McBSP related DT clock definitions
>    clk: ti: clk-3xxx-legacy: Correct McBSP related clock aliases
>
>   drivers/clk/ti/clk-3xxx-legacy.c | 16 +++++++++-------
>   drivers/clk/ti/clk-3xxx.c        | 19 +++++++------------
>   2 files changed, 16 insertions(+), 19 deletions(-)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/