linux-kernel - Re: [PATCH v3 0/4] input: ft5x06: Fix userspace reported maximum value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 12:05:05 -0700
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Lothar Waßmann <LW@...O-electronics.de>,
	Henrik Rydberg <rydberg@...omail.se>,
	linux-input@...r.kernel.org, Markus Pargmann <mpa@...gutronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/4] input: ft5x06: Fix userspace reported maximum
 value

On Tue, Mar 24, 2015 at 11:56:14AM -0700, Dmitry Torokhov wrote:
> On Tue, Mar 24, 2015 at 11:45:20AM -0700, Maxime Ripard wrote:
> > On Tue, Mar 24, 2015 at 09:47:22AM -0700, Dmitry Torokhov wrote:
> > > On Mon, Mar 23, 2015 at 05:10:02PM -0700, Maxime Ripard wrote:
> > > > Hi Lothar, Dmitry,
> > > > 
> > > > On Tue, Mar 03, 2015 at 02:50:42PM +0100, Maxime Ripard wrote:
> > > > > Hi,
> > > > > 
> > > > > The current ft5x06 reports to the user-space that its maximum
> > > > > coordinates are, on both X and Y, way higher than what could be
> > > > > actually usable on the screen (in my case, 5759x1151 instead of
> > > > > 480x800).
> > > > > 
> > > > > This causes trouble on some userspace stacks that then try to re-scale
> > > > > these coordinates back to the framebuffer resolution, like QT does.
> > > > > 
> > > > > Use the of_touchscreen code to find the real touchscreen limits in the
> > > > > DT case, and report that to the userspace.
> > > > 
> > > > Do you have any comments on that?
> > > 
> > > Yes, I'll apply it, although if you could supply the updated patch
> > > description for #1 that would be great. The current one seems from the
> > > old version and is no longer accurate.
> > > 
> > > Thanks.
> > 
> > You're right.
> > 
> > Would something like:
> > 
> > """
> > input: touchscreen: of: Rework the DT parsing function
> > 
> > The DT parsing function currently duplicates a lot of the code to
> > parse the touchscreen DT properties.
> > 
> > In order to ease further additions to this parsing routine, rework it
> > slightly to create new helper functions.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > """
> > 
> > be good enough?
> 
> Yep, thanks, I'll update the description, consider applied.
> 
> Thanks.

Great, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)