linux-kernel - Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 14:42:14 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Alessandro Zummo <a.zummo@...ertech.it>
Cc:	Xunlei Pang <pang.xunlei@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Richard Henderson <rth@...ddle.net>,
	Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

On Thu, Mar 19, 2015 at 4:29 PM, Alessandro Zummo <a.zummo@...ertech.it> wrote:
> On Wed, 18 Mar 2015 10:37:26 -0700
> John Stultz <john.stultz@...aro.org> wrote:
>
>> On Wed, Jan 28, 2015 at 10:27 AM, Alessandro Zummo <a.zummo@...ertech.it> wrote:
>> > On Thu, 29 Jan 2015 00:12:09 +0800
>> > Xunlei Pang <pang.xunlei@...aro.org> wrote:
>> >
>> >> ping Alessandro
>> >
>> >   -EBUSY . saw that, looks fine anyhow, but would like to
>> >  have a deeper look. we have still some time 'till 2038, right? ;)
>>
>> Hey Alessandro,
>>   I was hoping to let these go through you (with your review), but if
>> you're still too busy I can queue them if you'd rather.
>
>  Looks fine to me. The only thing that I would change
>  is the naming of the drivername_rtc_set_mmss in the drivers:
>  it should end with mmss64 when it's changed.
>
>  But that's probably just me being pedantic.
>
>  Acked-by: Alessandro Zummo <a.zummo@...ertech.it>
>
>  Can you please queue them?

Thanks for the review! I've queued them in my tree for 4.1

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/