linux-kernel - Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Open Source and information security mailing list archives

Message-ID: <CAHb8M2Ap7exg1wtRjD-+HKsTgv8vPEu3RRREf+n+5kSSuAAgLg@mail.gmail.com>
Date:	Tue, 24 Mar 2015 15:17:19 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Richard Weinberger <richard.weinberger@...il.com>,
	mfasheh@...e.com,
	"ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Joseph Qi <joseph.qi@...wei.com>
Subject: Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status
 for checking error

Hi, Andrew.

2015-03-20 10:17 GMT+09:00 Joseph Qi <joseph.qi@...wei.com>:
> Hi Andrew,
>
> On 2015/3/20 6:23, Andrew Morton wrote:
>> On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn <daeseok.youn@...il.com> wrote:
>>
>>> The use of 'status' in __ocfs2_add_entry() can return wrong
>>> status when some functions are failed.
>>>
>>> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed,
>>> that status is saved to 'status' but return variable is 'retval'
>>> which is saved 'success' status. In case of this,  __ocfs2_add_entry()
>>> is failed but can be returned as 'success'.
>>>
>>> So replace 'status' with 'retval'.
>>>
>>> -                                            mlog_errno(status);
>>> +                                    if (retval) {
>>> +                                            mlog_errno(retval);
>>>                                              goto bail;
>>
>> and
>>
>> bail:
>>       if (retval)
>>               mlog_errno(retval);
>>
>>       return retval;
>> }
>>
>> so we'll clearly log the same error twice.

As joseph comment, it doesn't need to cleanup mlog_errno() call in this patch.
And he reviewed this patch.

Check, please.

Thanks.
Daeseok Youn
>>
> IMO, if we only depends on the bail error log, we still don't know where
> the error occurs.
> So if we want to do the cleanup, the bail error log should be cleaned.
>
>> _______________________________________________
>> Ocfs2-devel mailing list
>> Ocfs2-devel@....oracle.com
>> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives