lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 24 Mar 2015 13:31:43 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	aaro.koskinen@....fi, nitinkuppelur@...il.com,
	pauldaviesc@...il.com, br@...amon.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: octeon-usb: Made octeon_usb_match const

On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
> 
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
> Acked-by: Aaro Koskinen <aaro.koskinen@....fi>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 1daeb31..9591232 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -3885,7 +3885,7 @@ static int octeon_usb_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct of_device_id octeon_usb_match[] = {
> +static const struct of_device_id octeon_usb_match[] = {
>  	{
>  		.compatible = "cavium,octeon-5750-usbc",
>  	},

Sorry, someone else sent this patch, and I saw their patch first before
yours, and applied it, which was my fault :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ