linux-kernel - Re: [PATCH v9 06/14] perf: Add AUX record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324130650.GB5337@krava.brq.redhat.com>
Date:	Tue, 24 Mar 2015 14:06:50 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Robert Richter <rric@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>, kan.liang@...el.com,
	markus.t.metzger@...el.com, mathieu.poirier@...aro.org,
	Kaixu Xia <kaixu.xia@...aro.org>, acme@...radead.org
Subject: Re: [PATCH v9 06/14] perf: Add AUX record

On Tue, Mar 24, 2015 at 01:27:22PM +0200, Adrian Hunter wrote:
> On 24/03/15 13:07, Jiri Olsa wrote:
> > On Wed, Jan 14, 2015 at 02:18:15PM +0200, Alexander Shishkin wrote:
> >> When there's new data in the AUX space, output a record indicating its
> >> offset and size and a set of flags, such as PERF_AUX_FLAG_TRUNCATED, to
> >> mean the described data was truncated to fit in the ring buffer.
> >>
> >> Signed-off-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> >> Cc: Arnaldo Carvalho de Melo <acme@...radead.org>
> >> ---
> >>  include/uapi/linux/perf_event.h | 19 +++++++++++++++++++
> >>  kernel/events/core.c            | 34 ++++++++++++++++++++++++++++++++++
> >>  kernel/events/internal.h        |  3 +++
> >>  3 files changed, 56 insertions(+)
> >>
> >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> >> index b7ccdf5e93..2d40e2aa07 100644
> >> --- a/include/uapi/linux/perf_event.h
> >> +++ b/include/uapi/linux/perf_event.h
> >> @@ -746,6 +746,20 @@ enum perf_event_type {
> >>  	 */
> >>  	PERF_RECORD_MMAP2			= 10,
> >>  
> >> +	/*
> >> +	 * Records that new data landed in the AUX buffer part.
> >> +	 *
> >> +	 * struct {
> >> +	 * 	struct perf_event_header	header;
> >> +	 *
> >> +	 * 	u64				aux_offset;
> >> +	 * 	u64				aux_size;
> >> +	 *	u64				flags;
> >> +	 * 	struct sample_id		sample_id;
> > 
> > hum, I dont see sample_id below in implementation
> 
> Alex is away, so I will take the liberty of answering.
> 
> perf_event_aux_event() calls perf_event__output_id_sample()
> That's it isn't it?

argh, now I see it ;-) sry

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/