linux-kernel - Re: [PATCH] mfd: axp20x: Fix duplicate const for model names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 15:06:41 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: axp20x: Fix duplicate const for model names

2015-03-24 14:53 GMT+01:00 Joe Perches <joe@...ches.com>:
> On Tue, 2015-03-24 at 11:21 +0100, Krzysztof Kozlowski wrote:
>> Replace duplicated const keyword for 'axp20x_model_names' with proper
>> array of const pointers to const strings.
>
> A few more of these exist:
>
> arch/arm/mach-bcm/bcm_cygnus.c:16:static const char const *bcm_cygnus_dt_compat[] = {
> drivers/clk/clk-si5351.c:71:static const char const *si5351_input_names[] = {
> drivers/clk/clk-si5351.c:74:static const char const *si5351_pll_names[] = {
> drivers/clk/clk-si5351.c:77:static const char const *si5351_msynth_names[] = {
> drivers/clk/clk-si5351.c:80:static const char const *si5351_clkout_names[] = {
> drivers/clk/clk-ls1x.c:83:static const char const *cpu_parents[] = { "cpu_clk_div", "osc_33m_clk", };
> drivers/clk/clk-ls1x.c:84:static const char const *ahb_parents[] = { "ahb_clk_div", "osc_33m_clk", };
> drivers/clk/clk-ls1x.c:85:static const char const *dc_parents[] = { "dc_clk_div", "osc_33m_clk", };
> sound/pci/asihpi/asihpi.c:2379:static const char const *sampleclock_sources[] = {
> sound/soc/sh/rcar/dvc.c:39:static const char const *dvc_ramp_rate[] = {

Thanks, I grepped them also :).

For the clk-si5351.c I sent a patch few weeks ago. Recently resent it:
https://lkml.org/lkml/2015/3/20/153

For the asihpi and rcard/dvc I just sent a patch few minutes ago.

The bcm_cygnus is already fixed by someone else.

The remaining clk-ls1x.c is on MIPS (MACH_LOONGSON1) which I cannot
compile now (I don't have MIPS cross-compiler). Maybe someone from
MIPS can fix it?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/