linux-kernel - Re: [PATCH] staging: rts5208: Fixed 80 char & indent warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 07:16:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ragavendra Nagraj <ragavendra.bn@...il.com>,
	micky_ching@...lsil.com.cn, gregkh@...uxfoundation.org,
	roxanagabriela10@...il.com, lambert.quentin@...il.com,
	vatikaharlalka@...il.com, robert.r.kmiec@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208: Fixed 80 char & indent warnings

On Tue, 2015-03-24 at 11:00 +0300, Dan Carpenter wrote:
> None of these are correct.  :(

True.  Please run your proposed patches through checkpatch
before sending them.

I think it would be an improvement to rework the flow-hiding
TRACE_RET and TRACE_GOTO macros into two separate lines.

It would also reduce the code size quite a bit if the TRACE
portion of TRACE_RET/TRACE_GOTO was a separate function and
not an inline.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/