linux-kernel - Re: [PATCH 2/9] tools lib traceevent: Copy trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324114334.5b43c362@gandalf.local.home>
Date:	Tue, 24 Mar 2015 11:43:34 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/9] tools lib traceevent: Copy trace_clock and free it

On Tue, 24 Mar 2015 12:14:49 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:

> Humm, strdup actually sets errno already, from its man page:
> 
> -------------------
> 
> RETURN VALUE
>        On success, the strdup() function returns a pointer to the
> duplicated string.  It returns NULL if insufficient memory was
> available, with errno set to indicate the cause of the error.
> 
> -------------------
> 
> 
> Applying anyway, as this doesn't introduces a problem, right?
> 

Ah, I didn't realize that. I probably should of. The original code just
had a "die()" in it. But I know how much Namhyung loves those ;-)

I removed the die() and noticed that the other removed "die()"s also
set errno = ENOMEM. Those probably could also be removed as they happen
after "remalloc" and such.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/