linux-kernel - Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 09:06:09 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] regulator: arizona-ldo1: Add ramp time for HI_PWR

On Tue, Mar 24, 2015 at 02:27:56PM +0000, Charles Keepax wrote:

> +static int arizona_ldo1_hc_set_voltage_time_sel(struct regulator_dev *rdev,
> +						unsigned int old_selector,
> +						unsigned int new_selector)
> +{
> +	/* if moving to 1.8v allow time for it to reach voltage */
> +	if (new_selector == rdev->desc->n_voltages - 1)
> +		return 25;
> +	else
> +		return 0;
> +}

So changes to move to the top voltage always take constant time while
all other voltage changes are instantaneous?  That doesn't seem right.
I'd expect something more like a calculation based on some number of
miliseconds per milivolt.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)