linux-kernel - Re: [PATCH v3 07/10] ntb: drop pci_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427213523.221225.30.camel@intel.com>
Date:	Tue, 24 Mar 2015 16:12:03 +0000
From:	"Jiang, Dave" <dave.jiang@...el.com>
To:	"mst@...hat.com" <mst@...hat.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"yhlu.kernel.send@...il.com" <yhlu.kernel.send@...il.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"jdmason@...zu.us" <jdmason@...zu.us>,
	"famz@...hat.com" <famz@...hat.com>
Subject: Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe

On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote:
> pci core now disables msi on probe automatically,
> drop this from device-specific code.
> 
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Acked-by: Dave Jiang <dave.jiang@...el.com>

> ---
>  drivers/ntb/ntb_hw.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c
> index cd29b10..8225cbc 100644
> --- a/drivers/ntb/ntb_hw.c
> +++ b/drivers/ntb/ntb_hw.c
> @@ -1313,8 +1313,6 @@ static int ntb_setup_intx(struct ntb_device *ndev)
>  	struct pci_dev *pdev = ndev->pdev;
>  	int rc;
>  
> -	pci_msi_off(pdev);
> -
>  	/* Verify intx is enabled */
>  	pci_intx(pdev, 1);
>