linux-kernel - RE: [PATCH 6/7] scsi: storvsc: Don't assume that the scatterlist is not chained

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN1PR0301MB0707EDA27C3C7D79463F34F7A00A0@BN1PR0301MB0707.namprd03.prod.outlook.com>
Date:	Tue, 24 Mar 2015 16:29:42 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Olaf Hering <olaf@...fle.de>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"jbottomley@...allels.com" <jbottomley@...allels.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>
Subject: RE: [PATCH 6/7] scsi: storvsc: Don't assume that the scatterlist is
 not chained



> -----Original Message-----
> From: Olaf Hering [mailto:olaf@...fle.de]
> Sent: Tuesday, March 24, 2015 1:56 AM
> To: KY Srinivasan
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; jbottomley@...allels.com;
> hch@...radead.org; linux-scsi@...r.kernel.org; apw@...onical.com;
> vkuznets@...hat.com; jasowang@...hat.com
> Subject: Re: [PATCH 6/7] scsi: storvsc: Don't assume that the scatterlist is not
> chained
> 
> On Mon, Mar 23, K. Y. Srinivasan wrote:
> 
> > @@ -653,32 +640,39 @@ static unsigned int
> copy_from_bounce_buffer(struct scatterlist *orig_sgl,
> >  	unsigned long bounce_addr = 0;
> >  	unsigned long dest_addr = 0;
> >  	unsigned long flags;
> > +	struct scatterlist *cur_dest_sgl;
> > +	struct scatterlist *cur_src_sgl;
> >
> >  	local_irq_save(flags);
> > -
> > +	cur_dest_sgl = orig_sgl;
> > +	cur_src_sgl = bounce_sgl;
> >  	for (i = 0; i < orig_sgl_count; i++) {
> > -		dest_addr = sg_kmap_atomic(orig_sgl,i) + orig_sgl[i].offset;
> > +		dest_addr = (unsigned long)
> > +				kmap_atomic(sg_page(cur_dest_sgl)) +
> > +				cur_dest_sgl->offset;
> >  		dest = dest_addr;
> >  		destlen = orig_sgl[i].length;
> > +		destlen = cur_dest_sgl->length;
> 
> Double assignment.

Thanks Olaf; I will fix this and resubmit.

K. Y

> 
> Olaf