linux-kernel - Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324163743.GE31024@saruman.tx.rr.com>
Date:	Tue, 24 Mar 2015 11:37:43 -0500
From:	Felipe Balbi <balbi@...com>
To:	Sudeep Holla <sudeep.holla@....com>
CC:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Felipe Balbi <balbi@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: isp1760: fix spin unlock in the error path of
 isp1760_udc_start

On Fri, Mar 20, 2015 at 02:27:40PM +0000, Sudeep Holla wrote:
> Hi Laurent,
> 
> On 20/03/15 14:20, Laurent Pinchart wrote:
> >Hi Sudeep,
> >
> >Thank you for the patch.
> >
> >On Friday 20 March 2015 11:42:17 Sudeep Holla wrote:
> >>Commit a124820de5fd ("usb: isp1760: fix possible deadlock in
> >>isp1760_udc_irq") replaced spin_{un,}lock with
> >>spin_{un,}lock_irq{save,restore}. However it missed an error path resulting
> >>in the smatch warning as below:
> >>
> >>drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn:
> >>inconsistent returns 'irqsave:flags'. Locked on:   line 1207
> >>Unlocked on: line 1199
> >>
> >>This patch fixes the spin unlock in the error path in isp1760_udc_start
> >>thereby removing the smatch warning mentioned above.
> >>
> >>Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> >>Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> >>Cc: Felipe Balbi <balbi@...com>
> >>Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> >
> >Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> >
> 
> Thanks
> 
> >>---
> >>  drivers/usb/isp1760/isp1760-udc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>Hi Laurent, Felipe,
> >>
> >>I am extremely sorry for missing this in my original patch.
> >
> >I hope you will be ashamed for the 7 generations to come for this totally
> >unacceptable low quality standard.
> >
> 
> Yes ;)

shameful indeed, doesn't build ;-)

drivers/usb/isp1760/isp1760-udc.c:1205:52: error: undefined identifier 'flags'
drivers/usb/isp1760/isp1760-udc.c: In function ‘isp1760_udc_start’:
drivers/usb/isp1760/isp1760-udc.c:1205:38: error: ‘flags’ undeclared (first use in this function)
   spin_unlock_irqrestore(&udc->lock, flags);
                                      ^
drivers/usb/isp1760/isp1760-udc.c:1205:38: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [drivers/usb/isp1760/isp1760-udc.o] Error 1
make[1]: *** [drivers/usb/isp1760] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers/usb/] Error 2

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)