linux-kernel - Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <201503241746.12446@pali>
Date:	Tue, 24 Mar 2015 17:46:12 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Santiago Gala <sgala@...che.org>
Cc:	Hans de Goede <hdegoede@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

Hello, I can compile psmouse.ko module for you. Just let me know 
which ubuntu kernel (and from) are you using.

On Tuesday 24 March 2015 11:25:13 Santiago Gala wrote:
> I can't compile the  kernel in this laptop, sorry, I tried but
> couln't complete: it requires too much free disk (more than
> 9GB) and the SSD is very small.
> 
> If there is a way (I have not found it even though I know that
> dkms exists) to just compile the modjule I could easily test
> the patch with the mainline ubuntu binary of the relevant
> 4.0.0-rcN, but spending some time trying it didn't show how
> to do i
> 
> Regards
> Santiago
> 
> El mar., 24 de marzo de 2015 a las 8:30, Hans de Goede
> (<hdegoede@...hat.com>)
> 
> escribió:
> > Hi,
> > 
> > On 23-03-15 18:02, Pali Rohár wrote:
> > > On Monday 23 March 2015 12:39:48 Hans de Goede wrote:
> > >> Hi,
> > >> 
> > >> On 22-03-15 14:46, Pali Rohár wrote:
> > >>> This patch adds detection of trackstick for v7 protocol
> > >>> devices. Code in this patch is used in official Dell
> > >>> touchpad linux drivers for Dell models: Dell Latitude
> > >>> E5250/5250, E5450/5450, E5550/5550
> > >>> 
> > >>> Detection code and base reg for alps v3 rushmore and v7
> > >>> devices is exacly same.
> > >>> 
> > >>> Also user in bug
> > >>> https://bugzilla.kernel.org/show_bug.cgi?id=94801
> > >>> reported that Toshiba Sattellite Z30-A-1DG has only
> > >>> alps v7 touchpad device without trackstick and kernel
> > >>> reports to userspace also redundant trackstick device.
> > >>> 
> > >>> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > >> 
> > >> Looks good, but has this been tested on a laptop which
> > >> actually has a v7 pad + trackstick? I would like to see
> > >> this actually tested on at least one such laptop before
> > >> it gets merged.
> > >> 
> > >> Regards,
> > >> 
> > >> Hans
> > > 
> > > I did not tested my patch on any v7 touchpad-only laptop.
> > 
> > Ah, but I'm not worried about testing on a touchpad-only
> > laptop, we are already reporting a trackpoint there even
> > though there is none. I'm worried about breaking existing
> > v7 using laptops which actually have a trackstick.
> > 
> > So if this is tested on a v7 laptop with trackstick, and it
> > does not break the trackstick then that is good enough for
> > me.
> > 
> > Regards,
> > 
> > Hans

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)