linux-kernel - Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5510DCCE.5060007@huawei.com>
Date:	Tue, 24 Mar 2015 11:41:02 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	kbuild test robot <fengguang.wu@...el.com>,
	"kbuild-all@...org" <kbuild-all@...org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [pci:pci/enumeration-yw7 32/35] drivers/pci/host-bridge.c:147:24:
 sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?

On 2015/3/24 10:29, Bjorn Helgaas wrote:
> On Mon, Mar 23, 2015 at 8:15 PM, Yijing Wang <wangyijing@...wei.com> wrote:
>>>> sparse warnings: (new ones prefixed by >>)
>>>>
>>>>>> drivers/pci/host-bridge.c:147:24: sparse: symbol 'pci_find_host_bridge' was not declared. Should it be static?
>>>>
>>>> Please review and possibly fold the followup patch.
>>>
>>> It does look like pci_find_host_bridge() is only used inside
>>> drivers/pci/host-bridge.c and could be static.  Given that it's only
>>> used there, it doesn't even need to be renamed, so maybe you could
>>> even just drop the rename patch, too.
>>
>> OK.
>>
>> Hi Bjorn, because this series involved lots platforms and host bridge chips, and this version takes a lot of changes.
>> So I didn't take lot of time to cross build this series in all the platforms in my local. I hope you could see the changes
>> first, and I will refresh and fix the details soon.
> 
> I just put them on a branch for build testing.  I will review them
> more closely when the build problems are resolved.
> 
> FYI, I'll be on vacation from Mar 25 - Apr 2, so I won't be able to do
> much then.

OK, I post out the new v8 version which fixed the build problems and drop the unnecessary patch.

Happy vacation!

Thanks!
Yijing.

> 
> Bjorn
> 
> 


-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/