linux-kernel - Re: [PATCH] staging: rtl8723au: Remove uses of MAC_FMT and MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wrfj8ueml0c9.fsf@redhat.com>
Date:	Tue, 24 Mar 2015 14:25:10 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723au: Remove uses of MAC_FMT and MAC_ARG

Joe Perches <joe@...ches.com> writes:
> Use the standard vsprintf kernel extension to format
> mac addresses.
>
> This reduces object code size a bit.
>
> Miscellanea:
>
> o Coalesce formats
> o Realign arguments
> o Remove the now unused MAC_FMT and MAC_ARG #defines
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c           | 41 ++++++-------
>  drivers/staging/rtl8723au/core/rtw_mlme.c         | 26 ++++----
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c     | 72 +++++++++++------------
>  drivers/staging/rtl8723au/core/rtw_recv.c         | 42 +++++--------
>  drivers/staging/rtl8723au/core/rtw_wlan_util.c    |  6 +-
>  drivers/staging/rtl8723au/core/rtw_xmit.c         |  8 +--
>  drivers/staging/rtl8723au/include/ieee80211.h     |  3 -
>  drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 18 +++---
>  drivers/staging/rtl8723au/os_dep/os_intfs.c       |  7 +--
>  9 files changed, 101 insertions(+), 122 deletions(-)

Looks good to me

Acked-by: Jes Sorensen <Jes.Sorensen@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/