linux-kernel - [PATCH] squashfs: return correct error value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 25 Mar 2015 01:49:09 -0400
From:	Sanidhya Kashyap <sanidhya.gatech@...il.com>
To:	phillip@...ashfs.org.uk, linux-kernel@...r.kernel.org
Cc:	taesoo@...ech.edu, changwoo@...ech.edu, sanidhya@...ech.edu,
	blee@...ech.edu, csong84@...ech.edu,
	Sanidhya Kashyap <sanidhya.gatech@...il.com>
Subject: [PATCH] squashfs: return correct error value

In the squashfs_symlink_readpage(), the return value should be -EIO
instead of 0 when the code fails in obtaining the information about
the symlink metadata.

Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@...il.com>
---
 fs/squashfs/symlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/squashfs/symlink.c b/fs/squashfs/symlink.c
index 12806df..791ab36 100644
--- a/fs/squashfs/symlink.c
+++ b/fs/squashfs/symlink.c
@@ -109,7 +109,7 @@ static int squashfs_symlink_readpage(struct file *file, struct page *page)
 error_out:
 	SetPageError(page);
 	unlock_page(page);
-	return 0;
+	return -EIO;
 }
 
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/