linux-kernel - Re: [PATCH] usb: chipidea: usbmisc_imx: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1503250723070.2205@localhost6.localdomain6>
Date:	Wed, 25 Mar 2015 07:23:52 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	kbuild test robot <fengguang.wu@...el.com>,
	peter.chen@...escale.com
cc:	kbuild@...org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] usb: chipidea: usbmisc_imx: fix returnvar.cocci
 warnings

Please take a look.

thanks,
julia

On Wed, 25 Mar 2015, kbuild test robot wrote:

> TO: Peter Chen <peter.chen@...escale.com>
> CC: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
> CC: linux-usb@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> 
> drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded variable: "ret". Return "0" on line 297
> 
> 
>  Removes unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Peter Chen <peter.chen@...escale.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  usbmisc_imx.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -274,7 +274,6 @@ static int usbmisc_imx6sx_init(struct im
>  	unsigned long flags;
>  	struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
>  	u32 val;
> -	int ret = 0;
>  
>  	usbmisc_imx6q_init(data);
>  
> @@ -294,7 +293,7 @@ static int usbmisc_imx6sx_init(struct im
>  		spin_unlock_irqrestore(&usbmisc->lock, flags);
>  	}
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static int usbmisc_vf610_init(struct imx_usbmisc_data *data)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/