linux-kernel - Re: [PATCH] Fix braces to GNU style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150325085840.GA32673@gmail.com>
Date:	Wed, 25 Mar 2015 09:58:40 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	carlossilveirajr@...il.com
Cc:	mingo@...hat.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix braces to GNU style


* carlossilveirajr@...il.com <carlossilveirajr@...il.com> wrote:

> From: Carlos Roberto Silveira Junior <carlossilveirajr@...il.com>
> 
> ---
>  kernel/sched/fair.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 7ce18f3..834aa55 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -296,13 +296,12 @@ static inline void list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
>  		 * reduces this to two cases.
>  		 */
>  		if (cfs_rq->tg->parent &&
> -		    cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list) {
> +		    cfs_rq->tg->parent->cfs_rq[cpu_of(rq_of(cfs_rq))]->on_list)
>  			list_add_rcu(&cfs_rq->leaf_cfs_rq_list,
>  				&rq_of(cfs_rq)->leaf_cfs_rq_list);
> -		} else {
> +		else
>  			list_add_tail_rcu(&cfs_rq->leaf_cfs_rq_list,
>  				&rq_of(cfs_rq)->leaf_cfs_rq_list);
> -		}
>  
>  		cfs_rq->on_list = 1;
>  		/* We should have no load, but we need to update last_decay. */
> @@ -505,9 +504,9 @@ static void __enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se)
>  		 * We dont care about collisions. Nodes with
>  		 * the same key stay together.
>  		 */
> -		if (entity_before(se, entry)) {
> +		if (entity_before(se, entry))
>  			link = &parent->rb_left;
> -		} else {
> +		else {
>  			link = &parent->rb_right;
>  			leftmost = 0;
>  		}

But in the kernel we are following the Linux kernel style.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/