linux-kernel - Re: Enable little endian kernel: misspelled Kconfig item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150325091208.GG1385@linux-mips.org>
Date:	Wed, 25 Mar 2015 10:12:08 +0100
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	david.daney@...ium.com, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org, lrosenboim@...iumnetworks.com,
	aleksey.makarov@...iga.com
Subject: Re: Enable little endian kernel: misspelled Kconfig item

On Wed, Mar 25, 2015 at 08:57:20AM +0100, Valentin Rothberg wrote:

> Hi David,
> 
> your commit 9861908f081f ("MIPS: OCTEON: Enable little endian kernel.")
> adds the following conditional select to arch/mips/Kconfig:
> 
> +       select SYS_SUPPORTS_HOTPLUG_CPU if CONFIG_CPU_BIG_ENDIAN
> 
> The problem is the 'CONFIG_' prefix for 'CPU_BIG_ENDIAN'.  The item is
> always off since the prefix does not work as we are in a Kconfig file.
> Hence, the if-statement never evaluates to true.
> 
> It can be fixed by simply removing the 'CONFIG_' prefix.
> 
> I detected this commit with ./scripts/checkkconfigsymbols.py.  Commit
> b1a3f243485f ("checkkconfigsymbols.py: make it Git aware") added support
> to check (and compare) undefined Kconfig symbols in Git commits.

I've folded in a fix for the issue.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/