linux-kernel - Re: [PATCH] cris: fix integer overflow in ELF_ET_DYN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150325103702.GF26081@axis.com>
Date:	Wed, 25 Mar 2015 11:37:02 +0100
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Andrey Ryabinin <a.ryabinin@...sung.com>
Cc:	Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jespern@...s.com>, linux-cris-kernel@...s.com,
	linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
	Yury Gribov <y.gribov@...sung.com>
Subject: Re: [PATCH] cris: fix integer overflow in ELF_ET_DYN_BASE

On Tue, Mar 24, 2015 at 06:31:23PM +0300, Andrey Ryabinin wrote:
> Almost all arches define ELF_ET_DYN_BASE as 2/3 of TASK_SIZE.
> Though it seems that some architectures do this in a wrong way.
> The problem is that 2*TASK_SIZE may overflow 32-bits so
> the real ELF_ET_DYN_BASE becomes wrong.
> Fix this overflow by dividing TASK_SIZE prior to multiplying:
> 	(TASK_SIZE / 3 * 2)

Good catch, thanks, added to the CRIS-tree.

> Signed-off-by: Andrey Ryabinin <a.ryabinin@...sung.com>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/