linux-kernel - Re: [PATCH 01/17] x86, fpu: wrap get_xsave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150325125613.GB17191@redhat.com>
Date:	Wed, 25 Mar 2015 13:56:13 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Rik van Riel <riel@...hat.com>
Cc:	Andy Lutomirski <luto@...capital.net>,
	Dave Hansen <dave.hansen@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	X86 ML <x86@...nel.org>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Suresh Siddha <sbsiddha@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 01/17] x86, fpu: wrap get_xsave_addr() to make it safer

On 03/24, Rik van Riel wrote:
>
> On 03/24/2015 08:18 PM, Andy Lutomirski wrote:
> Is there any reason not to rename __save_init_fpu to
> save_fpu_state, or just save_fpu?

Please see another email. __save_init_fpu() saves the FPU state
but it can also change the FPU registers. At least I think so ;)

Otherwise, why switch_fpu_prepare() resets .last_cpu if it returns
zero? And unlazy_fpu() should do the same.

This all needs the cleanups, yes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/