linux-kernel - Re: [PATCH v2 1/2] powerpc32: put csum_tcpudp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427249404.22867.86.camel@freescale.com>
Date:	Tue, 24 Mar 2015 21:10:04 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Christophe Leroy <christophe.leroy@....fr>
CC:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	<linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
Subject: Re: [PATCH v2 1/2] powerpc32: put csum_tcpudp_magic inline

On Tue, 2015-02-03 at 12:39 +0100, Christophe Leroy wrote:
> csum_tcpudp_magic() is only a few instructions, and does not modifies any other
> register than the returned result. So it is not worth having it as a separate
> function and suffer function branching and saving of volatile registers.
> This patch makes it inline by use of the already existing csum_tcpudp_nofold()
> function.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> 
> ---
> v2: no change
> 
>  arch/powerpc/include/asm/checksum.h | 15 +++++++++++++++
>  arch/powerpc/lib/checksum_32.S      | 16 ----------------
>  2 files changed, 15 insertions(+), 16 deletions(-)

The 64-bit version is pretty similar to the 32-bit -- why only use
csum_tcpudp_nofold() on 32-bit?

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/