linux-kernel - Re: [RFC PATCH 01/11] sysctl: make some functions unstatic to access by arch/lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2a8z1ccw2.wl@sfc.wide.ad.jp>
Date:	Thu, 26 Mar 2015 00:31:09 +0900
From:	Hajime Tazaki <tazaki@....wide.ad.jp>
To:	joe@...ches.com
Cc:	linux-arch@...r.kernel.org, arnd@...db.de, corbet@....net,
	cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
	iamjoonsoo.kim@....com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	netdev@...r.kernel.org, linux-mm@...ck.org, jdike@...toit.com,
	richard@....at, rusty@...tcorp.com.au, mathieu.lacage@...il.com
Subject: Re: [RFC PATCH 01/11] sysctl: make some functions unstatic to access by arch/lib


At Tue, 24 Mar 2015 09:13:39 -0700,
Joe Perches wrote:
> 
> On Tue, 2015-03-24 at 22:10 +0900, Hajime Tazaki wrote:
> > libos (arch/lib) emulates a sysctl-like interface by a function call of
> > userspace by enumerating sysctl tree from sysctl_table_root. It requires
> > to be publicly accessible to this symbol and related functions.
> []
> > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> []
> > @@ -77,7 +77,7 @@ static int namecmp(const char *name1, int len1, const char *name2, int len2)
> >  }
> >  
> >  /* Called under sysctl_lock */
> > -static struct ctl_table *find_entry(struct ctl_table_header **phead,
> > +struct ctl_table *find_entry(struct ctl_table_header **phead,
> 
> find_entry and all of the <foo>_entry functions below it
> are overly generic names.  Maybe prefix with ctl_table_

agree.
I will address this in the next version of the patch.

thanks.

-- Hajime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/