linux-kernel - Re: [PATCH 1/1] hfsplus: incorrect return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABikg9xW3xJE0XADN5f-ydk_U02unq=veBkUB-ywBFpODq+zcw@mail.gmail.com>
Date:	Wed, 25 Mar 2015 16:34:39 +0100
From:	Sergei Antonov <saproj@...il.com>
To:	Chengyu Song <csong84@...ech.edu>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org, taesoo@...ech.edu,
	changwoo@...ech.edu, sanidhya@...ech.edu, blee@...ech.edu,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] hfsplus: incorrect return value

Reviewed-by: Sergei Antonov <saproj@...il.com>

CC-ing Andrew Morton.

On 25 March 2015 at 01:44, Chengyu Song <csong84@...ech.edu> wrote:
> In case of memory allocation error, the return should be -ENOMEM,
> instead of -ENOSPC.
>
> Signed-off-by: Chengyu Song <csong84@...ech.edu>
> ---
>  fs/hfsplus/dir.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/dir.c b/fs/hfsplus/dir.c
> index f0235c1..3074609 100644
> --- a/fs/hfsplus/dir.c
> +++ b/fs/hfsplus/dir.c
> @@ -434,7 +434,7 @@ static int hfsplus_symlink(struct inode *dir, struct dentry *dentry,
>  {
>         struct hfsplus_sb_info *sbi = HFSPLUS_SB(dir->i_sb);
>         struct inode *inode;
> -       int res = -ENOSPC;
> +       int res = -ENOMEM;
>
>         mutex_lock(&sbi->vh_mutex);
>         inode = hfsplus_new_inode(dir->i_sb, S_IFLNK | S_IRWXUGO);
> @@ -476,7 +476,7 @@ static int hfsplus_mknod(struct inode *dir, struct dentry *dentry,
>  {
>         struct hfsplus_sb_info *sbi = HFSPLUS_SB(dir->i_sb);
>         struct inode *inode;
> -       int res = -ENOSPC;
> +       int res = -ENOMEM;
>
>         mutex_lock(&sbi->vh_mutex);
>         inode = hfsplus_new_inode(dir->i_sb, mode);
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/