linux-kernel - Re: [PATCH] x86/wmi: delete unused wmi_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150325172635.GA19129@fury.dvhart.com>
Date:	Wed, 25 Mar 2015 10:26:35 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/wmi: delete unused wmi_data_lock mutex causing gcc
 warning

On Mon, Mar 23, 2015 at 02:01:37PM -0400, Paul Gortmaker wrote:
> In commit bff431e49ff531a343fbb2b4426e313000844f32 ("ACPI: WMI: Add
> ACPI-WMI mapping driver") this mutex was added, but the rest of the
> final commit never actually made use of it, resulting in:
> 
>  In file included from include/linux/mutex.h:29:0,
>                   from include/linux/kernfs.h:13,
>                   from include/linux/sysfs.h:15,
>                   from include/linux/kobject.h:21,
>                   from include/linux/device.h:17,
>                   from drivers/platform/x86/wmi.c:35:
>  drivers/platform/x86/wmi.c:48:21: warning: ‘wmi_data_lock’ defined but not used [-Wunused-variable]
>   static DEFINE_MUTEX(wmi_data_lock);
>                       ^
> 
> A git grep shows no other instances/references to the wmi_data_lock.
> Delete it, assuming that the mutex addition was just a leftover from
> an earlier work in progress version of the change, since the original
> dates from 2008.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Queued, thank you Paul.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/