lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 25 Mar 2015 18:43:51 +0100
From:	Ioan Nicu <ioan.nicu.ext@....com>
To:	Peter Korsgaard <peter.korsgaard@...co.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Alexander Sverdlin <alexander.sverdlin@...ia.com>,
	Mathias Rulf <mathias.rulf@...ia.com>
Subject: [PATCH] i2c: i2c-mux-gpio: Change log level to debug for probe
 deferrals

Probe deferral is not an error case. It happens only when
the necessary dependencies are not there yet.

The driver core is already printing a message when a driver
requests probe deferral, so this can be traced in the logs
without these error prints.

This patch changes the error messages from these deferral cases
to debug messages.

Signed-off-by: Ionut Nicu <ioan.nicu.ext@...ia.com>
---
 drivers/i2c/muxes/i2c-mux-gpio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index f5798eb..9f1cfca 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -77,7 +77,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
        }
        adapter = of_find_i2c_adapter_by_node(adapter_np);
        if (!adapter) {
-               dev_err(&pdev->dev, "Cannot find parent bus\n");
+               dev_dbg(&pdev->dev, "Cannot find parent bus\n");
                return -EPROBE_DEFER;
        }
        mux->data.parent = i2c_adapter_id(adapter);
@@ -178,7 +178,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
 
        parent = i2c_get_adapter(mux->data.parent);
        if (!parent) {
-               dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
+               dev_dbg(&pdev->dev, "Parent adapter (%d) not found\n",
                        mux->data.parent);
                return -EPROBE_DEFER;
        }
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ