linux-kernel - Re: [PATCH 2/2] spi: Add driver for the CPLD chip on Mikrotik RB4xx boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeGo8MT+p8eSAsZ8s+Re_qyd_v+BfE2yzNhOXsViOT5cA@mail.gmail.com>
Date:	Wed, 25 Mar 2015 23:45:34 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Bert Vermeulen <bert@...t.com>, Ralf Baechle <ralf@...ux-mips.org>,
	linux-mips@...ux-mips.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-spi@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: Add driver for the CPLD chip on Mikrotik RB4xx boards

On Fri, Mar 20, 2015 at 3:28 PM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Mar 20, 2015 at 01:16:33PM +0100, Bert Vermeulen wrote:
>> The CPLD is connected to the NAND flash chip and five LEDs. Access to
>> those devices goes via this driver.
>
> None of this driver looks like a SPI controller - this appears to be a
> MFD so should have a core in drivers/mfd with function drivers for the
> individual features in the relevant subsystem directories.

I can add that even in this case better to use devm_* API, remove
unneded lines an so on. Seems like driver really far from modern
kernel API (2010 was written and mostly wasn't changed?).

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/