linux-kernel - Re: [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150325224253.GA16950@dtor-ws>
Date:	Wed, 25 Mar 2015 15:42:53 -0700
From:	Dmitry Torokhov <dtor@...gle.com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	Arun Ramamurthy <arun.ramamurthy@...adcom.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-kernel@...r.kernel.org, Anatol Pomazau <anatol@...gle.com>,
	Jonathan Richardson <jonathar@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	Ray Jui <rjui@...adcom.com>
Subject: Re: [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy
 driver

Hi Kishon,

On Thu, Mar 26, 2015 at 03:58:50AM +0530, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Saturday 21 March 2015 02:55 AM, Arun Ramamurthy wrote:
> > +struct bcm_phy_driver {
> > +	void __iomem *usbphy_regs;
> > +	void __iomem *usb2h_idm_regs;
> > +	void __iomem *usb2d_idm_regs;
> > +	struct bcm_phy_instance *ports[MAX_PHY_PORTS];
> 
> er.. can't we allocate this dynamically?

The chip has support for only 3 phys, so I believe allocating array of 3
pointers is simplest.

[...]

> > +
> > +static struct phy *bcm_usb_phy_xlate(struct device *dev,
> > +				     struct of_phandle_args *args)
> > +{
> > +	struct bcm_phy_driver *phy_driver = dev_get_drvdata(dev);
> > +	struct bcm_phy_instance *port = NULL;
> > +	int i;
> > +
> > +	if (!phy_driver)
> > +		return ERR_PTR(-EINVAL);
> > +
> > +	if (WARN_ON(args->args_count != 1))
> > +		return ERR_PTR(-EINVAL);
> > +
> > +	if (WARN_ON(args->args[0] < 0 || args->args[0] > 1))
> > +		return ERR_PTR(-EINVAL);
> > +
> > +	for (i = 0; i < ARRAY_SIZE(phy_driver->ports); i++) {
> > +		struct bcm_phy_instance *p = phy_driver->ports[i];
> > +
> > +		if (p && p->generic_phy->dev.of_node == args->np) {
> > +			port = p;
> > +			break;
> > +		}
> > +	}
> > +
> > +	if (!port) {
> > +		dev_err(dev, "Failed to locate phy %s\n", args->np->name);
> > +		return ERR_PTR(-EINVAL);
> > +	}
> > +
> > +	port->host_mode = args->args[0];
> > +
> > +	return port->generic_phy;
> > +}
> 
> The xlate function here shouldn't be needed at all. Use of_phy_simple_xlate
> instead.

of_phy_simple_xlate() will not allow specifying host vs device mode when
requesting phy though...

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/