linux-kernel - Re: [PATCH 1/5] usb: phy: twl4030: make runtime pm more reliable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150326063950.GA755@amd>
Date:	Thu, 26 Mar 2015 07:39:50 +0100
From:	Pavel Machek <pavel@....cz>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	NeilBrown <neil@...wn.name>, Tony Lindgren <tony@...mide.com>,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	GTA04 owners <gta04-owner@...delico.com>,
	NeilBrown <neilb@...e.de>
Subject: Re: [PATCH 1/5] usb: phy: twl4030: make runtime pm more reliable.

> > diff --git a/drivers/phy/phy-twl4030-usb.c
    b/drivers/phy/phy-twl4030-usb.c
> > index 8e87f54671f3..1a244f34b748 100644
> > --- a/drivers/phy/phy-twl4030-usb.c
> > +++ b/drivers/phy/phy-twl4030-usb.c
> > @@ -144,6 +144,16 @@
> >  #define PMBR1				0x0D
> >  #define GPIO_USB_4PIN_ULPI_2430C	(3 << 0)
> >  
> > +/*
> > + * If VBUS is valid or ID is ground, then we know a
> > + * cable is present and we need to be runtime-enabled
> > + */
> > +static inline bool cable_present(enum omap_musb_vbus_id_status stat)
> 
> twl4030_cable_present?

It is static function, no need for prefixes, they just make code
harder to read.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/