linux-kernel - Re: [withdrawn] zsmalloc-remove-extra-cond_resched-in-__zs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150326002717.GA1669@swordfish>
Date:	Thu, 26 Mar 2015 09:27:17 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	minchan@...nel.org
Cc:	akpm@...ux-foundation.org, sergey.senozhatsky@...il.com,
	ngupta@...are.org, sfr@...b.auug.org.au,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [withdrawn]
 zsmalloc-remove-extra-cond_resched-in-__zs_compact.patch removed from -mm
 tree

On (03/25/15 13:25), akpm@...ux-foundation.org wrote:
> The patch titled
>      Subject: zsmalloc: remove extra cond_resched() in __zs_compact
> has been removed from the -mm tree.  Its filename was
>      zsmalloc-remove-extra-cond_resched-in-__zs_compact.patch
> 
> This patch was dropped because it was withdrawn
> 
> ------------------------------------------------------
> From: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Subject: zsmalloc: remove extra cond_resched() in __zs_compact
> 
> Do not perform cond_resched() before the busy compaction loop in
> __zs_compact(), because this loop does it when needed.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Cc: Minchan Kim <minchan@...nel.org>
> Cc: Nitin Gupta <ngupta@...are.org>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  mm/zsmalloc.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff -puN mm/zsmalloc.c~zsmalloc-remove-extra-cond_resched-in-__zs_compact mm/zsmalloc.c
> --- a/mm/zsmalloc.c~zsmalloc-remove-extra-cond_resched-in-__zs_compact
> +++ a/mm/zsmalloc.c
> @@ -1717,8 +1717,6 @@ static unsigned long __zs_compact(struct
>  	struct page *dst_page = NULL;
>  	unsigned long nr_total_migrated = 0;
>  
> -	cond_resched();
> -
>  	spin_lock(&class->lock);
>  	while ((src_page = isolate_source_page(class))) {
>  

Hello,

Minchan, did I miss your NACK on this patch? or could you please ACK it?

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/